Add realpath for $mock_cache_path var, fix tests/code when PrivateTmp=on in systemd on mac enabled #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proggga
force-pushed
the
fix_systemd_PrivateTmp
branch
from
4d1b9da to
4ccb510
Compare
|
I will rebase, after #51 will be merged. (Contains composer2 fix - special fix for travis) |
proggga
changed the title
proggga
force-pushed
the
fix_systemd_PrivateTmp
branch
from
4ccb510 to
4b216e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got failed tests on my mac
So I made a little research and found a problem here.
Test compares real path in /private/tmp, and path that we concat.
They are differ (cause Mac had set PrivateTmp=on in systems), so I've added realdir to fix this behaviour
Also fixed path for lock file