Skip to content

Commit

Permalink
Update files
Browse files Browse the repository at this point in the history
  • Loading branch information
raminqaf committed Jul 4, 2024
1 parent 4063e1e commit b494f05
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion kpops/components/streams_bootstrap/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ class StreamsBootstrap(HelmApp, ABC):
def warning_for_latest_image_tag(self) -> Self:
if self.validate_ and self.app.image_tag == "latest":
log.warning(
f"The imageTag for component '{self.name}' is set or defaulted to 'latest'. Please, consider providing a stable imageTag."
f"The image tag for component '{self.name}' is set or defaulted to 'latest'. Please, consider providing a stable image tag."
)
return self
3 changes: 3 additions & 0 deletions tests/components/test_streams_bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def test_default_configs(self, config: KpopsConfig, handlers: ComponentHandlers)
)
assert streams_bootstrap.version == "2.9.0"
assert streams_bootstrap.namespace == "test-namespace"
assert streams_bootstrap.app.image_tag == "latest"

@pytest.mark.asyncio()
async def test_should_deploy_streams_bootstrap_app(
Expand All @@ -63,6 +64,7 @@ async def test_should_deploy_streams_bootstrap_app(
**{
"namespace": "test-namespace",
"app": {
"imageTag": "1.0.0",
"streams": {
"outputTopic": "test",
"brokers": "fake-broker:9092",
Expand Down Expand Up @@ -94,6 +96,7 @@ async def test_should_deploy_streams_bootstrap_app(
"test-namespace",
{
"nameOverride": "${pipeline.name}-example-name",
"imageTag": "1.0.0",
"streams": {
"brokers": "fake-broker:9092",
"outputTopic": "test",
Expand Down

0 comments on commit b494f05

Please sign in to comment.