Skip to content

Commit

Permalink
Refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
disrupted committed Jul 9, 2024
1 parent b23336f commit dd344a4
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions kpops/utils/dict_differ.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
from __future__ import annotations

from collections.abc import Mapping
from collections.abc import Mapping, MutableMapping
from dataclasses import dataclass
from difflib import Differ
from enum import Enum
from typing import TYPE_CHECKING, Generic, TypeVar
from typing import TYPE_CHECKING, Any, Generic, TypeVar

import typer
import yaml
Expand Down Expand Up @@ -79,16 +79,17 @@ def __find_changed_key(key_1: list[str] | str, key_2: str = "") -> str:
return f"{key_1}.{key_2}"


def render_diff(d1: Mapping, d2: Mapping, ignore: set[str] | None = None) -> str | None:
d1 = dict(d1)
d2 = dict(d2)

def del_ignored_keys(d: dict) -> None:
def render_diff(
d1: MutableMapping[str, Any],
d2: MutableMapping[str, Any],
ignore: set[str] | None = None,
) -> str | None:
def del_ignored_keys(d: MutableMapping[str, Any]) -> None:
"""Delete key to be ignored, dictionary is modified in-place."""
if ignore:
for i in ignore:
key_path = i.split(".")
nested = d1
nested = d
try:
for key in key_path[:-1]:
nested = nested[key]
Expand Down

0 comments on commit dd344a4

Please sign in to comment.