Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor component prefix & name #326

Merged
merged 39 commits into from
Sep 5, 2023
Merged

Refactor component prefix & name #326

merged 39 commits into from
Sep 5, 2023

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Aug 17, 2023 •
edited
Loading

Don't concat prefix and name to override component name anymore. Instead, they are now separate properties

disrupted added 30 commits August 15, 2023 16:28
@disrupted
Refactor Kafka Connect wrapper
67c2511
@disrupted
Refactor Kafka Connect wrapper
42a3f52
@disrupted
Refactor Kafka Connect handler
0d113ea
@disrupted
Exclude TestComponent from pytest
a94118b
@disrupted
Rename Connector config model
877a826
@disrupted
Fix import of typing.Self
08cd97c
@disrupted
Refactor
f52193a
@disrupted
Mark todo
da2d10e
@disrupted
Add alias generator and connector class validator
ef2eab1 
Fix connector class validator
@disrupted
Refactor connector name handling
b4f5d43
@disrupted
Update snapshot
1e9d5bb
@disrupted
Update snapshot
b186f85
@disrupted
Update tests
891c025
@disrupted
Hide connector config name field from schema because it is optional
418f2e4
@disrupted
Refactor connector tests
c29ae85
@disrupted
Refactor connector tests
f257dcd
@disrupted
Refactor connector tests
fe8e9c2
@disrupted
Make dry_run a kw-only argument
093aaa7
@disrupted
Fix edge case where connector config name is set to empty string
9a39722
@disrupted
Fix test assertions
eb47ac5
@disrupted
Fix connector name not containing prefix
b7e7fc4
@disrupted
Rename parameter
3f2fdd0
@disrupted
Print invalid connector class
c93a718
@disrupted
Extract local variable
a0f3c8d
@disrupted
Refactor
8b5b05a
@disrupted
Add component full_name property
f7171af 
prefix + name
@disrupted
Update tests
a5147df
@disrupted
Update pipeline tests
3cfe984
@disrupted
Merge remote-tracking branch 'origin/main' into refactor/component-na…
c19bfff 
…me-prefix
@disrupted
Update test
c7a2a1c
@disrupted disrupted added type/refactor Refactoring of existing functionality component/pipeline-components Related to pipeline components labels Aug 17, 2023
@disrupted disrupted self-assigned this Aug 17, 2023
@disrupted disrupted mentioned this pull request Aug 17, 2023
Merged
@disrupted disrupted marked this pull request as ready for review August 30, 2023 15:39
sujuka99
sujuka99 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@sujuka99 sujuka99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change :)

LGTM!

irux
irux approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@irux irux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@disrupted disrupted merged commit 8106788 into main Sep 5, 2023
8 checks passed
@disrupted disrupted deleted the refactor/component-name-prefix branch September 5, 2023 08:41
@disrupted disrupted mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujuka99 sujuka99 sujuka99 approved these changes

@raminqaf raminqaf raminqaf approved these changes

@irux irux irux approved these changes

Assignees

@disrupted disrupted

Labels
component/pipeline-components Related to pipeline components type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disrupted @irux @raminqaf @sujuka99