Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image tag field to streams-bootstrap app values #499

Merged
merged 28 commits into from
Jul 8, 2024
Merged

Add image tag field to streams-bootstrap app values #499

merged 28 commits into from
Jul 8, 2024

Conversation

raminqaf
Copy link
Contributor

No description provided.

@raminqaf raminqaf self-assigned this Jun 26, 2024
@raminqaf raminqaf requested a review from disrupted June 26, 2024 11:42
@raminqaf raminqaf changed the title Add image tag field to Kubernetes App values Add image tag field to Streamsbootstrap App values Jun 26, 2024
@raminqaf raminqaf added type/enhancement New feature or request component/pipeline-components Related to pipeline components labels Jun 26, 2024
@disrupted disrupted changed the title Add image tag field to Streamsbootstrap App values Add image tag field to streams-bootstrap app values Jun 27, 2024
@raminqaf raminqaf requested a review from disrupted July 4, 2024 13:21
disrupted
disrupted requested changes Jul 4, 2024
View reviewed changes
kpops/api/exception.py Outdated Show resolved Hide resolved
kpops/component_handlers/kafka_connect/model.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted July 4, 2024 13:48
disrupted
disrupted reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, otherwise LGTM

kpops/components/streams_bootstrap/__init__.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested review from disrupted and removed request for irux and sujuka99 July 8, 2024 11:39
@raminqaf raminqaf merged commit 0c0a8db into main Jul 8, 2024
9 checks passed
@raminqaf raminqaf deleted the feature/add-image-tag branch July 8, 2024 11:57
@DerTiedemann DerTiedemann mentioned this pull request Jul 12, 2024
Merged
@DerTiedemann DerTiedemann mentioned this pull request Jul 29, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

Assignees

@raminqaf raminqaf

Labels
component/pipeline-components Related to pipeline components type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raminqaf @disrupted