Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string type errors function #15

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

artemnvkv
Copy link

Added an additional check is_binary before String.valid?, because since version 15 of Elixir, the function String.valid? only accepts strings, otherwise we get an error

    ** (FunctionClauseError) no function clause matching in String.valid?/2

     The following arguments were given to String.valid?/2:

         # 1
         1.0

         # 2
         :default

     Attempted function clauses (showing 2 out of 2):

         def valid?(<<string::binary>>, :default)
         def valid?(<<string::binary>>, :fast_ascii)

@sofakingworld sofakingworld merged commit 8ec0a30 into balance-platform:master Jun 19, 2024
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants