Fix pool init error for pool creation UI #509
Open
+753
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPereira
commented
Nov 29, 2024
Comment on lines
+71
to
+82
| const vaultExplorer = getContract({ | ||
| abi: vaultExplorerAbi_V3, | ||
| address: VAULT_EXPLORER_V3[chainId], | ||
| client: client, | ||
| }); | ||
| return (await vaultV3.read.getPoolTokens([poolAddress])) as Address[]; | ||
| return (await vaultExplorer.read.getPoolTokens([ | ||
| poolAddress, | ||
| ])) as Address[]; | ||
| } catch (e) { | ||
| console.warn(e); | ||
| throw new Error( | ||
| `Error: Unable to get pool tokens using this pool address: ${poolAddress}`, | ||
| `Unable to get pool tokens using this pool address: ${poolAddress}`, |
There was a problem hiding this comment.
Leaning towards bug is probably on the pool creation UI side of things if SDK tests arent failing
Somehow I am able to manually recreate poolstate and it works fine, but attempt to fetch with SDK results in PoolNotRegistered error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't seem to figure out why SDK query for poolState is failing. See code comment below
I have confirmed using the vaultExplorer contract that the pool is registered and
getPoolTokensworks there.At this point, I'm unsure if bug is in SDK or pool creation UI
Resources
0xF5A25990da505a9d4C3E0d876f3951E9EDF9ABC30xBC582d2628FcD404254a1e12CB714967Ce4289150xa9F171e84A95c103aD4aFAC3Ec83810f9cA193a8