-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failing intermittently #606
Conversation
Main change: adapt anvil fork to mine blocks every 1 second, instead of default behavior of instant auto-mine after every transaction. Worth noting that this caused issues with how we read balances to check for success. Apparently Also, apparently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brunoguerios Fantastic job hunting down the solution for this one! 🎉
Will be so nice to not have to re-run the tests for future PRs / releases 😌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes Bruno.
@@ -51,7 +51,7 @@ const sDAI = TOKENS[chainId].sDAI; | |||
const BRLA = TOKENS[chainId].BRLA; | |||
|
|||
// skipping until we figure out why test is failing on CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment
I'm tracking down the source of the issue here. Apparently the issue lies in the |
Sharing what I found so you're aware:
|
Also:
Closes #565