Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price impact helper (v2) #1069

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Price impact helper (v2) #1069

wants to merge 8 commits into from

Conversation

EndymionJkb
Copy link
Collaborator

Description

Intended as a replacement for #323, which is so far out-of-date it would be an unreadable diff if we tried to update it in place. Test doesn't pass; next step might be for the original author to look at this version. (I have very little context here.)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • [N/A] The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants