Add UI for pixel history for dual source output and blend src/dest #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, no backend sets this, and it is not displayed.
Currently, no backend sets them, and they are not displayed.
Before, if a row was selected, the color was completely replaced, which makes the color preview column completely useless for that row. This change also fixes some inconsistencies with how the selection hover works on tree widgets; previously part of the row was not highlighted.
This is already implemented by all backends, but did not get displayed beforehand. This column is not visible by default.
This has not yet been implemented by any backends, not is the column visible by default.
They have not yet been implemented by any backends, not are the columns visible by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split from #3003; depends on (and includes a copy of) #3009.
This PR modifies the pixel history UI to add additional columns for dual source blend and the blend source/destination components. Currently, those are not implemented for any API. It also adds a column for the previous color, for which data was already obtained but not visible in the UI. All of these columns are hidden by default.
It also fixes a few minor UI issues: there was a mistake in the right-click message on pixel history where the message was "
Debug Pixel (<x>, <y>) primitive <event> at Event <primitive>", and the color columns in the pixel history view were always shown in the same color if the column was selected (now, the actual color is blended with the selection color to make things a bit clearer).