Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clang-format in 8 threads #3463

Closed
wants to merge 1 commit into from

Conversation

ShabbyX
Copy link
Contributor

@ShabbyX ShabbyX commented Oct 25, 2024

For faster runs of ./util/clang_format_all.sh

For faster runs of ./util/clang_format_all.sh
@baldurk
Copy link
Owner

baldurk commented Oct 28, 2024

I'm going to decline this because it looks like -P is not a standard xargs parameter so I don't know how portable this is. Normally it would be good enough, but since clang_format_all.sh should be rarely run I don't think this is worth making it potentially break somewhere.

Anyone who's developing regularly for RenderDoc should either have IDE integration format files, or use something like git clang-format to format only modified files. This brute force format of the whole repo is only used either for CI to check formatting or for someone who maybe doesn't care to properly set up clang-format at all. A minute to run the script in that case is not the end of the world.

@baldurk baldurk closed this Oct 28, 2024
@ShabbyX
Copy link
Contributor Author

ShabbyX commented Oct 28, 2024

Ah interesting, didn't know about git clang-format. Thank you, that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants