Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow d3d12 insert null rt descriptor #3468

Merged
merged 1 commit into from
Oct 31, 2024
Merged

allow d3d12 insert null rt descriptor #3468

merged 1 commit into from
Oct 31, 2024

Conversation

Mario-Cui
Copy link
Contributor

@Mario-Cui Mario-Cui commented Oct 29, 2024 •
edited
Loading

Description

d3d12 allow create null rendertarget view,
when replay rdc, we need allow null rendertarget view
display, match application behavior

old ui display
image

new ui display
image

baldurk
baldurk approved these changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@baldurk baldurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I will merge once CI is passing.

@Mario-Cui Mario-Cui changed the title allow d3d12 rendertarget insert null descriptor, match application be… allow d3d12 null rt descriptor, match application behavior Oct 29, 2024
@Mario-Cui Mario-Cui changed the title allow d3d12 null rt descriptor, match application behavior allow d3d12 insert null rt descriptor Oct 29, 2024
@baldurk baldurk merged commit 6f95cf2 into baldurk:v1.x Oct 31, 2024
16 checks passed
@Mario-Cui Mario-Cui deleted the c_dev branch November 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldurk baldurk baldurk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-Cui @baldurk