Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes wget package from dockerfile #151

Conversation

Iznogohul
Copy link
Contributor

@Iznogohul Iznogohul commented Jul 18, 2023

Change-type: patch
Removes the 'wget' package from the Dockerfile template, resulting in a Docker image size reduction to approximately 754.92MB (compared to ~755.86MB). Every bit counts, right? #42

P.S.:

Also noticed this branch about updating the base image to Debian 12 for Balena Browser. Woulid be awesome to have latest stable software with the same functionality however, it's worth mentioning that going with Debian 12 (Bookworm) would significantly increase the Docker image size to 1 GB+. This got me thinking about alternative approaches. To ensure both the latest mesa version and a relatively small Docker image, I decided to undertake a rewrite of the project here

Rewrite inclues

  • NestJs
  • Swagger Docs (sort of)
  • latest LTS Node.js version that balena supports
  • Removed bent package in favor of native fetch
  • Alpine as the base docker image + multi staged build
    As a result, the Docker image size was around ~750MB.
    However, to ensure optimal performance and compatibility on real hardware, further testing is required. Currently, I only have an RPi3 B+ available for testing.

@klutchell klutchell force-pushed the perf/remove-wget-from-docker branch from 9331db2 to 2e40a74 Compare July 18, 2023 17:20
@klutchell
Copy link
Contributor

Thanks for the contribution!

Can you please add a Change-type: patch to the body of your commit message?

You can find the guidelines for our semantic versioning system here: https://github.com/balena-io/docs/blob/master/CONTRIBUTING.md#creating-commits-in-line-with-semantic-versioning

@Iznogohul
Copy link
Contributor Author

@klutchell Took me a while but made the correct patch commit

@klutchell
Copy link
Contributor

Could you also squash those 5 commits into one from the command line?
https://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git-squash/13231

@Iznogohul Iznogohul force-pushed the perf/remove-wget-from-docker branch 2 times, most recently from c9e1cac to 56e45f9 Compare July 19, 2023 16:50
@Iznogohul
Copy link
Contributor Author

@klutchell should be fine now

patch: remove wget from dockerfile
@klutchell klutchell force-pushed the perf/remove-wget-from-docker branch from 56e45f9 to b5bfbd5 Compare July 19, 2023 18:31
@klutchell
Copy link
Contributor

lgtm!

@klutchell klutchell merged commit 1db0c64 into balena-io-experimental:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants