Skip to content

Commit

Permalink
Skip tests on aarch64 where nested KVM is not available
Browse files Browse the repository at this point in the history
We don't have any ARM64 GitHub VM runners with KVM, as nested
KVM is currently only available on x86_64.

Previously we were testing with containerized runners
so they had access to the host kernel, but it is insecure
to use self-hosted runners on public repositories such
as this.

Signed-off-by: Kyle Harding <[email protected]>
  • Loading branch information
klutchell committed Apr 18, 2024
1 parent 9911f13 commit 57db12f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/flowzone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
with:
docker_runs_on: >
{
"linux/amd64": ["self-hosted","runtime:container","X64"],
"linux/arm64": ["self-hosted","runtime:container","ARM64"]
"linux/amd64": ["self-hosted","X64"],
"linux/arm64": ["self-hosted","ARM64"]
}
docker_images: >
ghcr.io/balena-io-experimental/container-jail
5 changes: 5 additions & 0 deletions docker-compose.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ services:
- /bin/sh
- -c
- |
if [[ "$(uname -m)" != "x86_64" ]] && [[ -z "$(ls /dev/kvm)" ]]; then
echo "Nested KVM unavailable on this architecture!"
exit 0
fi
set -ex
apk add --no-cache docker-cli-compose
Expand Down

0 comments on commit 57db12f

Please sign in to comment.