Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable netfilter comment matching #50

Closed
wants to merge 6 commits into from
Closed

Enable netfilter comment matching #50

wants to merge 6 commits into from

Commits on Apr 18, 2024

  1. Enable netfilter comment matching 

    See: https://www.kernelconfig.io/config_ip_nf_match_comment
Change-type: patch
Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d5158c0 View commit details
    Browse the repository at this point in the history

  2. Add test for iptables comments 

    Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9911f13 View commit details
    Browse the repository at this point in the history

  3. Skip tests on aarch64 where nested KVM is not available 

    We don't have any ARM64 GitHub VM runners with KVM, as nested
KVM is currently only available on x86_64.

Previously we were testing with containerized runners
so they had access to the host kernel, but it is insecure
to use self-hosted runners on public repositories such
as this.

Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    57db12f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Revert "Enable netfilter comment matching" 

    This reverts commit d5158c0.

Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    91537b1 View commit details
    Browse the repository at this point in the history

  2. Test on actuated runners 

    Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6f59a9b View commit details
    Browse the repository at this point in the history

  3. Test comments with iptables-nft 

    Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    26c274a View commit details
    Browse the repository at this point in the history