-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: Add GHA Built Test Deploy workflows #142
Conversation
Changelog-entry: Add GHA Built Test Deploy workflows Signed-off-by: Ryan Cooke <[email protected]>
5418403
to
8a69166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT, I would like to start providing the worker_type
in the test matrix and a newline at the EOF is preferred for linting.
Otherwise it's looks good
@klutchell to make it explicit that |
Yes, though it's not required I find it helpful at the repo level to quickly see what the worker type is rather than read the comment and deduce it. |
Adds build deploy test workflow
balena-cloud.com