Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Add GHA Built Test Deploy workflows #142

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Sep 25, 2024

Adds build deploy test workflow

  • Create PR with all devices supported
  • Set deploy environment to balena-cloud.com
  • Disable the associated multi-job and device jobs in Jenkins
  • All required devices are passing on GHA + doesn't require a rebase
  • Approved by the reviewer (policy-bot passed)
  • Update branch protection to require the GHA workflows
  • Remove Jenkins build and deploy workflow (this PR)

Changelog-entry:  Add GHA Built Test Deploy workflows
Signed-off-by: Ryan Cooke <[email protected]>
Copy link
Contributor

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT, I would like to start providing the worker_type in the test matrix and a newline at the EOF is preferred for linting.

Otherwise it's looks good

@vipulgupta2048
Copy link
Member

@klutchell to make it explicit that worker_type is actually testbot?

@klutchell
Copy link
Contributor

@klutchell to make it explicit that worker_type is actually testbot?

Yes, though it's not required I find it helpful at the repo level to quickly see what the worker type is rather than read the comment and deduce it.

@flowzone-app flowzone-app bot merged commit 92fd29f into master Oct 2, 2024
52 checks passed
@flowzone-app flowzone-app bot deleted the ryan/gha branch October 2, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants