Merge pull request #457 from balena-os/ryan/permissions

Explicitly set GITHUB_TOKEN permissions for yocto workflow
balena-os · Nov 29, 2024 · cf3a5a7 · cf3a5a7
2 parents 48c2a17 + 2747838
commit cf3a5a7
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 15 deletions.
diff --git a/.github/workflows/radxa-cm3-io-rk3566.yml b/.github/workflows/radxa-cm3-io-rk3566.yml
@@ -9,10 +9,10 @@ on:
       - master
       # ESR branches glob pattern
       #- 20[0-9][0-9].[0-1]?[1470].x
-  # pull_request_target:
-  #   branches:
-  #     - main
-  #     - master
+  pull_request_target:
+    branches:
+      - main
+      - master
   push:
     tags:
       # Semver tags glob pattern (includes ESR in format v20YY.MM.PATCH)
@@ -31,11 +31,17 @@ on:
         type: string
         default: balena-staging.com
 
+permissions:
+  id-token: write # This is required for requesting the JWT #https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#requesting-the-access-token
+  actions: read # We are fetching workflow run results of a merge commit when workflow is triggered by new tag, to see if tests pass
+  pull-requests: write # Read is required to fetch the PR that merged, in order to get the test results. Write is required to create PR comments for workflow approvals.
+  packages: read
+  contents: read
 
 jobs:
   yocto:
     name: Yocto
-    uses: balena-os/balena-yocto-scripts/.github/workflows/yocto-build-deploy.yml@05b373abd099d1862fdff51e96b0122940505756 # v1.27.15
+    uses: balena-os/balena-yocto-scripts/.github/workflows/yocto-build-deploy.yml@master
     # Prevent duplicate workflow executions for pull_request (PR) and pull_request_target (PRT) events.
     # Both PR and PRT will be triggered for the same pull request, whether it is internal or from a fork.
     # This condition will prevent the workflow from running twice for the same pull request while

diff --git a/.github/workflows/radxa-zero-s905y2.yml b/.github/workflows/radxa-zero-s905y2.yml
@@ -9,10 +9,10 @@ on:
       - master
       # ESR branches glob pattern
       #- 20[0-9][0-9].[0-1]?[1470].x
-  # pull_request_target:
-  #   branches:
-  #     - main
-  #     - master
+  pull_request_target:
+    branches:
+      - main
+      - master
   push:
     tags:
       # Semver tags glob pattern (includes ESR in format v20YY.MM.PATCH)
@@ -31,11 +31,17 @@ on:
         type: string
         default: balena-staging.com
 
+permissions:
+  id-token: write # This is required for requesting the JWT #https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#requesting-the-access-token
+  actions: read # We are fetching workflow run results of a merge commit when workflow is triggered by new tag, to see if tests pass
+  pull-requests: write # Read is required to fetch the PR that merged, in order to get the test results. Write is required to create PR comments for workflow approvals.
+  packages: read
+  contents: read
 
 jobs:
   yocto:
     name: Yocto
-    uses: balena-os/balena-yocto-scripts/.github/workflows/yocto-build-deploy.yml@05b373abd099d1862fdff51e96b0122940505756 # v1.27.15
+    uses: balena-os/balena-yocto-scripts/.github/workflows/yocto-build-deploy.yml@master
     # Prevent duplicate workflow executions for pull_request (PR) and pull_request_target (PRT) events.
     # Both PR and PRT will be triggered for the same pull request, whether it is internal or from a fork.
     # This condition will prevent the workflow from running twice for the same pull request while

diff --git a/.github/workflows/rockpi-4b-rk3399.yml b/.github/workflows/rockpi-4b-rk3399.yml
@@ -9,10 +9,10 @@ on:
       - master
       # ESR branches glob pattern
       - 20[0-9][0-9].[0-1]?[1470].x
-  # pull_request_target:
-  #   branches:
-  #     - main
-  #     - master
+  pull_request_target:
+    branches:
+      - main
+      - master
   push:
     tags:
       # Semver tags glob pattern (includes ESR in format v20YY.MM.PATCH)
@@ -31,11 +31,17 @@ on:
         type: string
         default: balena-staging.com
 
+permissions:
+  id-token: write # This is required for requesting the JWT #https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#requesting-the-access-token
+  actions: read # We are fetching workflow run results of a merge commit when workflow is triggered by new tag, to see if tests pass
+  pull-requests: write # Read is required to fetch the PR that merged, in order to get the test results. Write is required to create PR comments for workflow approvals.
+  packages: read
+  contents: read
 
 jobs:
   yocto:
     name: Yocto
-    uses: balena-os/balena-yocto-scripts/.github/workflows/yocto-build-deploy.yml@05b373abd099d1862fdff51e96b0122940505756 # v1.27.15
+    uses: balena-os/balena-yocto-scripts/.github/workflows/yocto-build-deploy.yml@master
     # Prevent duplicate workflow executions for pull_request (PR) and pull_request_target (PRT) events.
     # Both PR and PRT will be triggered for the same pull request, whether it is internal or from a fork.
     # This condition will prevent the workflow from running twice for the same pull request while