Update dependencies node 20 pt 3 #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cywang117
force-pushed
the
update-dependencies-node-20-pt-3
branch
from
529f961 to
ebf3670
Compare
|
@cywang117 husky might be ESM but the supervisor doesn't import it anywhere, it's only used as essentially a binary |
|
PRed the husky update in #2323 |
TODO: Upgrading io-ts to 2.2.21 will result in some unit tests for io-ts type validation breaking, due to a change in t.record's handling of decoding unknown objects. In <2.2.21, a record with a custom key type will decode an unknown object to Left if it has a key is not of the custom type. Whereas in [email protected], t.record will strip the invalid key and decode to Right. This is a breaking change for us. Change-type: patch Signed-off-by: Christina Ying Wang <[email protected]>
Change-type: patch Signed-off-by: Christina Ying Wang <[email protected]>
cywang117
force-pushed
the
update-dependencies-node-20-pt-3
branch
from
ebf3670 to
23ba3e4
Compare
|
@balena-ci I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io-tsto 2.2.21 instead of the 2.2.20 it was upgraded to here would require someio-tstype rewrites due to a bugfix in 2.2.21 (see non-enumerable records with extra keys do not passio-ts.record.is, contrary to TypeScript types gcanti/io-ts#704) so it's not a trivial change.chaicannot be bumped to v5, norhuskyto v9, norpretty-msto v9, due to the Supervisor still being a CommonJS module and the aforementioned packages moving to ESM in those versions. Doing so will result in theERR_REQUIRE_ESMerror until we can migrate to an ESM module (type: modulein package.json). See: chaijs/chai#1561Node 22 should help with ESM <--> CJS interoperability, see docs. We can revisit some NPM bumps after a Node upgrade.
Closes: #2321, #2320, #2319, #2315, #2290