Feature/lcb support dev #358
Conversation
| @@ -0,0 +1 @@ | |||
| SRC_URI = "git://github.com/intel/${BPN};branch=main;protocol=https" | |||
There was a problem hiding this comment.
Do you use bmap-tools? What is the purpose?
There was a problem hiding this comment.
Not explicitly. We just use the balenaos-img output.
The build does, however, generate some ..rootfs.bmap outputs by default in image_types_balena.bbclass, which could be used with the bmaptool for flashing.
This commit was more for cleaning up the build log to remove warnings.
| @@ -33,3 +33,9 @@ ROOTFS_POSTPROCESS_COMMAND += "topicbalena_rootfs_postprocess; " | |||
| # We need to increase the rootfs size to make space for additional drivers in ROOTFS. | |||
| # BalenaOS image has a 700MB max size defined in 'image_types_balena.bbclass' | |||
| IMAGE_ROOTFS_SIZE="409600" | |||
|
|
|||
There was a problem hiding this comment.
What is this needed for? Isn't /etc/os-release enough to provide with the info you need?
There was a problem hiding this comment.
os-release has a 'nice' version of BalenaOS, but a commit hash is the absolute truth.
I suppose this only helps while developing on a branch, where the os-release stays fixed. On the 'master'/'production' BalenaOS os-release does get stepped quite regularly.
Doesn't hurt to have it here, but I can easily remove it as well.
| @@ -0,0 +1,28 @@ | |||
| From 91c0364479b932f473f72671c140d566dc758891 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Shouldn't all these patches be in the BSP layer instead, the meta-topic submodule?
There was a problem hiding this comment.
The machine (lcbzu9) that has been added consists of a Topic SoM module on top of the client's custom carrier board.
It is therefore technically not part of the Topic PCBs and not supported by meta-topic.
If you don't think these fit in meta-balena-topic, a workable suggestion might be to add something like "meta-lowpad".
Then I would move everything required to support the lowpad carrier board, including these patches, the machine.conf, fpga & device tree there.
Do you agree?
There was a problem hiding this comment.
I would rather we move all these to a meta-lowpad layer.
But if you are in a hurry now, we can merge them like this and you can move all lcbzu9 code at a later time in the new layer.
floion
force-pushed
the
feature/lcb-support-dev
branch
from
41e37f9 to
91945db
Compare
FrancoisLoubser-1
force-pushed
the
feature/lcb-support-dev
branch
2 times, most recently
from
00c6ede to
44dc6b5
Compare
The lcb board requires kernel 5.15.36 Change-type: patch Signed-off-by: Francois Loubser <[email protected]>
Add git revision to deployed filesystem for Software Baseline Identification process. Signed-off-by: Francois Loubser <[email protected]>
No functional change, fixes warning about patch "fuzz". Signed-off-by: Mike Looijmans <[email protected]>
Installing npm is tricky apparently, so provide detailed instructions to prevent the obscure package errors "apt install npm" often reports. Signed-off-by: Mike Looijmans <[email protected]>
Solves a fetch error for bmap-tools, apparently upstream renamed master. Signed-off-by: Mike Looijmans <[email protected]>
Adding lcbzu9 machine Changelog-entry: Add lcbzu9 machine Signed-off-by: Francois Loubser <[email protected]>
Port patches from lowpad_lcb_platform https://bitbucket.topic.nl/projects/LOW/repos/lowpad-lcb-platform/browse Signed-off-by: Francois Loubser <[email protected]>
The fpga image, maintained by Topic, is packaged here. Signed-off-by: Francois Loubser <[email protected]>
bootloader generated by meta-xilinx requies patch for the lcb board to get SD card to work. Easiest fix was to download the binary generated by Topic/lowpad-lcb-platform build, which generates a valid boot.bin from XSA. Signed-off-by: Francois Loubser <[email protected]>
The coffeemaker script is no longer relevant, remove it and keep the coffee files in the repo. Adjust .gitignore for that too. Add lcbzu9.coffee for the Eurotec Lowpad carrier board. Signed-off-by: Mike Looijmans <[email protected]>
Signed-off-by: Francois Loubser <[email protected]>
floion
force-pushed
the
feature/lcb-support-dev
branch
from
44dc6b5 to
e400ae5
Compare
No description provided.