Skip to content

Commit

Permalink
Drop the client-side public-read ACL and inherit from the bucket
Browse files Browse the repository at this point in the history
Signed-off-by: Kyle Harding <[email protected]>
  • Loading branch information
klutchell committed Dec 17, 2024
1 parent 9128d7e commit d59c88f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/yocto-build-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,6 @@ jobs:
continue-on-error: true
env:
SHARED_DOWNLOADS_DIR: ${{ github.workspace }}/shared/shared-downloads
S3_ACL: public-read
S3_SSE: AES256
S3_URL: "s3://${{ env.DOWNLOADS_MIRROR_BUCKET }}/shared-downloads"
S3_REGION: ${{ env.DOWNLOADS_MIRROR_REGION }}
Expand All @@ -658,7 +657,7 @@ jobs:
run: |
sudo ln -sf "${{ github.workspace }}" /work
ls -al "${SHARED_DOWNLOADS_DIR}/"
aws s3 sync --sse="${S3_SSE}" --acl="${S3_ACL}" "${SHARED_DOWNLOADS_DIR}/" "${S3_URL}/" \
aws s3 sync --sse="${S3_SSE}" "${SHARED_DOWNLOADS_DIR}/" "${S3_URL}/" \
--exclude "*/*" --exclude "*.tmp" --size-only --follow-symlinks --no-progress
# TODO: pre-install on self-hosted-runners
Expand Down

0 comments on commit d59c88f

Please sign in to comment.