Publish raw and flasher images separately #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Michal Toman <[email protected]>
…her images At this moment we are providing a single balena.img file that is either raw or flasher based on the coffee script. We want to publish both for some device types, therefore split the single file into balena-raw.img and balena-flasher.img. Temporarily keep the existing balena.img for backwards compatibility until all coffee scripts are updated and image maker is aware of the split. Change-type: minor Signed-off-by: Michal Toman <[email protected]>
No functional change, just refactor a section of the script to make it more readable. Change-type: patch Signed-off-by: Michal Toman <[email protected]>
mtoman
force-pushed
the
publish_raw_and_flasher
branch
from
6d979c2 to
1b34cd9
Compare
alexgg
reviewed
Mar 9, 2021
There was a problem hiding this comment.
@mtoman it's been a while since this was discussed, what was the motivation for this again?
I would rather not keep three copies of the image. We should push for the image maker change to be done first, and then we can remove the balena.zip file. Device integration layers will adapt their coffee files as they update to new balena-yocto-scripts versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment we only publish a single
balena.imgwhich is either a flasher image or a raw image based on the device configuration. There is no simple way of telling the type without looking at the metadata. We also want to publish both raw and flasher images for devices that use flasher. This patch adds two new filesbalena-raw.imgandbalena-flasher.imgwhile keeping the originalbalena.imgfor backwards compatibility.Please be aware that after merge this will mean double disk space consumption for non-flasher DTs and triple disk space consumption for DTs that use flasher.