Build and publish helper images with Flowzone #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/publish-images
branch
8 times, most recently
from
ee53c73 to
226b3e5
Compare
klutchell
added a commit
to balena-os/balena-generic
that referenced
this pull request
Jan 31, 2024
See: balena-os/balena-yocto-scripts#324 Changelog-entry: Test unmerged changes to balena-yocto-scripts Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-os/balena-generic
that referenced
this pull request
Jan 31, 2024
See: balena-os/balena-yocto-scripts#324 Changelog-entry: Test unmerged changes to balena-yocto-scripts Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/publish-images
branch
from
76e1a33 to
da2e1d3
Compare
klutchell
added a commit
to balena-os/balena-generic
that referenced
this pull request
Jan 31, 2024
See: balena-os/balena-yocto-scripts#324 Changelog-entry: Test unmerged changes to balena-yocto-scripts Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/publish-images
branch
from
da2e1d3 to
eae1168
Compare
|
Integration tests: balena-os/balena-generic#405 |
klutchell
requested review from
a team and
rcooke-warwick
and removed request for
rcooke-warwick
alexgg
requested changes
Feb 2, 2024
There was a problem hiding this comment.
lgtm - I could approve as is. Just a note that some of the changes are on paths that are not currently used to it would maybe simplify things to PR the clean-up and then modify this PR.
But anyway I could approve it as it too as the paths are unused anyway - feel free to self certify.
Rather than build helper images on demand, we will publish them to ghcr.io with every revision of this project. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/publish-images
branch
from
eae1168 to
12ebad2
Compare
Also refactor the pull helper image functions to support a single repository with multiple variant tags. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/publish-images
branch
from
12ebad2 to
f2fb173
Compare
klutchell
added a commit
to balena-os/balena-generic
that referenced
this pull request
Feb 2, 2024
See: balena-os/balena-yocto-scripts#324 Changelog-entry: Test unmerged changes to balena-yocto-scripts Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-os/balena-generic
that referenced
this pull request
Feb 2, 2024
See: balena-os/balena-yocto-scripts#324 Changelog-entry: Test unmerged changes to balena-yocto-scripts Signed-off-by: Kyle Harding <[email protected]>
alexgg
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than build helper images on demand, we will publish them to ghcr.io with every revision of this project.
Change-type: minor