-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose secure boot testing features via matrix input #412
Conversation
c650fa1
to
83ec56d
Compare
83ec56d
to
f9861f7
Compare
f9861f7
to
3217352
Compare
3217352
to
6b12cb9
Compare
6b12cb9
to
e59aa5e
Compare
e59aa5e
to
7eb3e36
Compare
https://github.com/balena-os/leviathan/blob/master/action.yml#L46 There is a conflict here - with the SB matrix it tries to make artifacts with the same name amd fails |
@rcooke-warwick Do you have a run where the conflict appears. With Kyle's change, it seems we won't be doing a normal run when secureboot will be enabled. Hence, yes the artifacts could be better named to exactly show the secureboot run but there won't be other artifacts present? |
There are other artifacts present because there is a SB and non SB version of the tests run, and both produce artifacts with the same name E.g https://github.com/balena-os/balena-generic/actions/runs/11216427427/job/31184440638?pr=530
We need another variable in the artifact name to differentiate it |
We also still need to figure out why the SB enables DUT never comes online , even after the 4G memory being enabled |
This fix will have to be in the Leviathan workflow to generate unique artifact names -- ideally unique with a bunch of properties, like machine, signed/unsigned, worker type, etc. @vipulgupta2048 |
f4975e0
to
4ec4d43
Compare
balena-os/leviathan#1243 here is a shot at that |
4ec4d43
to
ed07cdb
Compare
ed07cdb
to
8503147
Compare
Some device types (generic-armd64) need to run the test suites twice for the same base image, once with secure boot vars enabled in Leviathan, and once without. Rather than run the suites in series, or require building the image twice, we can allow the test matrix to define separate runs for the two modes. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
8503147
to
922d1dd
Compare
Some device types (generic-armd64) need to run the test
suites twice for the same base image, once with secure boot
vars enabled in Leviathan, and once without.
Rather than run the suites in series, or require building the
image twice, we can allow the test matrix to define separate runs
for the two modes.