Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Stop persisting credentials in actions/checkout #416

Merged
merged 1 commit into from
Sep 30, 2024
Merged

patch: Stop persisting credentials in actions/checkout #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/yocto-build-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,9 @@ jobs:
repository: balena-io/private-contracts
token: ${{ steps.app-token-balena-io.outputs.token }}
path: ${{ github.workspace }}/private-contracts
# Do not persist the token credentials,
# and prefer that each step provide credentials where required
persist-credentials: false

# Unrolled balena_api_is_dt_private function - https://github.com/balena-os/balena-yocto-scripts/blob/master/automation/include/balena-api.inc#L424
# Had to be unrolled due to this: https://github.com/balena-os/balena-yocto-scripts/blob/master/automation/include/balena-lib.inc#L191 function relying on a jenkins env var to select the balena env - so failed
Expand Down Expand Up @@ -1133,6 +1136,9 @@ jobs:
repository: balena-io/private-contracts
token: ${{ steps.app-token-balena-io.outputs.token }}
path: ${{ env.LEVIATHAN_ROOT }}/core/private-contracts
# Do not persist the token credentials,
# and prefer that each step provide credentials where required
persist-credentials: false

# Image was uploaded uncompressed and Leviathan test config.js expects the image in a certain place and with a certain name
# The balena.img file is downloaded to ${WORKSPACE}/image/balena.img
Expand Down
Loading