Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins_build.sh: upload .bmap files to s3 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michal-mazurek
Copy link
Contributor

fix some whitespaces while here

fix some whitespaces while here

Signed-off-by: Michal Mazurek <[email protected]>
@michal-mazurek
Copy link
Contributor Author

Will COMPRESSED or ARCHIVE invalidate the usefulness of a .bmap file? When are these options used? Can they be removed?

readlink --canonicalize seems to be GNU-only, but I think that's fine.

connect balena-os/balena-beaglebone#71

@michal-mazurek
Copy link
Contributor Author

connect balena-os/balena-os#163

floion
floion previously approved these changes Feb 23, 2017
@agherzan
Copy link
Contributor

Needs rebasing but looks good.

@lurch
Copy link

lurch commented Jun 20, 2018

ping @jhermsmeier since I guess this would be useful for Etcher too?

@kaisoz kaisoz added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Jun 10, 2020
@ghost ghost dismissed floion’s stale review June 10, 2020 15:48

Approval reviews not allowed in Draft PRs

@agherzan
Copy link
Contributor

@michal-mazurek @floion Shall we close this? It looks like an old piece of work. Otherwise please unsign me as a reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flow/in-review versionbot/pr-draft Draft PR - Don't merge this PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants