Work around uuid file corruption in balenaEngine health check #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbarros
force-pushed
the
lmb/corrupted-uuid-file
branch
from
1b0b38b to
eab468d
Compare
klutchell
reviewed
Apr 26, 2024
| # Check for all the possible formats, starting with the most common one, to | ||
| # benefit from the short-circuited evaluation. The contents of the uuid file | ||
| # must match these formats exactly, so we anchor the regexes both at the | ||
| # beginning (^) and the end ($). |
There was a problem hiding this comment.
Love the detailed comments!
There was a problem hiding this comment.
I believe time travel is impossible, because otherwise I'd expect someone to have come back to thank me for those 😝
klutchell
approved these changes
May 14, 2024
alexgg
force-pushed
the
lmb/corrupted-uuid-file
branch
from
eab468d to
4d17f0b
Compare
|
@resin-jenkins retest this please |
lmbarros
force-pushed
the
lmb/corrupted-uuid-file
branch
2 times, most recently
from
a09d9e0 to
1281755
Compare
|
@resin-jenkins retest this please |
alexgg
force-pushed
the
lmb/corrupted-uuid-file
branch
from
1281755 to
9dbb95c
Compare
lmbarros
force-pushed
the
lmb/corrupted-uuid-file
branch
from
9dbb95c to
2986278
Compare
We have detected one more way in which the uuid file used by containerd can get corrupted. This time, the file is not empty, but doesn't contain a valid UUID either. This commit thus extends the existing workaround to also handle this case. See balena-os/balena-engine#322 Signed-off-by: Leandro Motta Barros <[email protected]> Change-type: patch
lmbarros
force-pushed
the
lmb/corrupted-uuid-file
branch
from
2986278 to
e3696fc
Compare
|
@resin-jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have detected one more way in which the uuid file used by containerd can get corrupted. This time, the file is not empty, but doesn't contain a valid UUID either.
This commit thus extends the existing workaround to also handle this case.
See balena-os/balena-engine#322
Testing
I tested this manually only. I built balenaOS for raspberrypi3-64 using my branch of meta-balena and flashed it to a device. Then I tried to manually change the contents of the
uuidfile and run the health check to see the results:uuidfile remained unchanged.uuidfile was created.In other words, no form of bad
uuidshould not cause the Engine healthcheck to fail after this change.Regarding automated tests: I believe it should be possible to add some automated test cases for that -- basically automate the kind of manual testing I described above. I am not so sure this would add significant value, though. (FWIW, we don't have automated tests for the current version of this workaround)
Contributor checklist
Change-typepresent on at least one commitSigned-off-byis presentReviewer Guidelines