Initial submission to provide Production build support for Walt-explorer #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting "Development" build. It essentially addresses the requirement of the following story to some extent: ballercat#128 To execute production build, "build:prod" mode has been added to package.json (in ~/packages/walt-docs/) It reduces output JS file, explorer.js, by about 50% Following testings have been performed for this submission: - manually loading explorer.js file from /docs folder - npm test
ballercat
requested changes
Oct 27, 2018
packages/walt-docs/package.json
Outdated
| @@ -7,6 +7,7 @@ | |||
| "start": "webpack-dev-server -d --hot --inline", | |||
| "start-container": "webpack-dev-server -d --hot --inline --host=$(hostname -I | xargs)", | |||
| "build": "webpack && cp index.html explorer.js explorer.js.map walt.png ../../docs/", | |||
| "build:prod": "cross-env NODE_ENV=production webpack && cp index.html explorer.js explorer.js.map walt.png ../../docs/", | |||
There was a problem hiding this comment.
There isn't much of a point to keep both prod and dev build commands so let's just use build for this, drop the old command entirely.
There was a problem hiding this comment.
I had similar thoughts. Will do the changes now as you have suggested. Thanks!
- Renamed "walt-docs" to "walt-explorer" at ~/packages/ - Made "build" linked to production instead of having two similar naming builds [build, development] & [build:prod, production] in ~packages/walt-explorer/package.json
ballercat
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This submission supports "Production" build mode, in addition to, existing "Development" build. It essentially addresses the requirement of the following story to some extent:
#128
To execute production build, "build:prod" mode has been added to package.json (in ~/packages/walt-docs/)
It reduces output JS file, explorer.js, by about 50%
Following testings have been performed for this submission: