samba4: fix build with gcc14 and on older OS

net/samba4/Portfile

@@ -30,7 +30,7 @@ distname            samba-${version}
 
 perl5.major         5.34
 
-depends_build       port:pkgconfig \
+depends_build       path:bin/pkg-config:pkgconfig \
                     port:gettext \
                     port:bison
 
@@ -81,6 +81,9 @@ patchfiles-append patch-samba-install.diff
 # https://bugzilla.samba.org/show_bug.cgi?id=15763
 patchfiles-append   patch-ldb-wscript.diff
 
+# Add a missing header for renameat.
+patchfiles-append   patch-vfs_default.c.diff
+
 configure.perl      ${perl5.bin}
 configure.python    ${prefix}/bin/python3.12
 configure.env-append \
@@ -98,6 +101,12 @@ configure.args      -C \
                     --with-gpgme \
                     --disable-spotlight
 
+# https://trac.macports.org/ticket/71494
+if {[string match *gcc* ${configure.compiler}]} {
+    configure.cflags-append \
+                    -Wno-error=incompatible-pointer-types
+}
+
 build.pre_args
 build.env-append    PYTHON=${configure.python} DESTDIR=${destroot}
 

net/samba4/files/patch-vfs_default.c.diff

@@ -0,0 +1,10 @@
+--- source3/modules/vfs_default.c
++++ source3/modules/vfs_default.c	2024-12-09 15:33:36.000000000 +0800
+@@ -37,6 +37,7 @@
+ #include "offload_token.h"
+ #include "util_reparse.h"
+ #include "lib/util/string_wrappers.h"
++#include <sys/stdio.h> /* renameat */
+
+ #undef DBGC_CLASS
+ #define DBGC_CLASS DBGC_VFS