131 feature hmr #138
Merged
131 feature hmr #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds HMR to
commandsandeventssources file!Nodemon is still enabled for all the other paths. So you'll have nearly instant reload times when editing commands and events, and still benefit of nodemon auto restart fonctionality when editing other source files.
It also removes the quite useless
dev:startnpm script, feel free to add it again if you need it.Note that it is the very first version and prototype of HMR and will likely be enhanced in the future, with a main focus on extending it on as many as possible of source files (services, extensions, etc). Any help is welcomed in order to achieve this goal!