Don't defer the read

basecamp · Dec 2, 2024 · 040aacb · 040aacb
1 parent dd84e2e
commit 040aacb
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/internal/server/health_check.go b/internal/server/health_check.go
@@ -95,11 +95,9 @@ func (hc *HealthCheck) check() {
 		hc.reportResult(false, err)
 		return
 	}
-
-	defer func() {
-		_, _ = io.Copy(io.Discard, resp.Body)
-		resp.Body.Close()
-	}()
+        defer resp.Body.Close()
+
+        _, _ = io.Copy(io.Discard, resp.Body)
 
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		hc.reportResult(false, fmt.Errorf("%w (%d)", ErrorHealthCheckUnexpectedStatus, resp.StatusCode))