Improve testing helper functions #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to using testing.TB interface instead of *testing.T. - Add t.Helper() to helper functions to ensure failure reports point to correct test lines. - Use the standard t.TempDir() for a temporary folder creation. - Ensure errors are checked when starting the test server.
kevinmcconnell
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks @erka, that's great!
FWIW, the shortTmpDir helper existed due to some test failures that happened whenever the tempfile path was very long, which happened sometimes on macOS. This no longer seems to be a problem though, so I think that previous length restriction is no longer an issue. Nice that we can remove it now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct test lines.