Support sshkit.default_env #1279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have any Ruby experience, so if I'm doing something very silly here please let me know so I can fix it. |
Enables deploy to MacOS hosts. Will still need further configuration though: - `default_env` needs to be set to a PATH that contains docker and coreutils `cp` - desktop docker config needs to have no `credsStore` - shell needs to be changed to `bash` All this can be done by the user though, whereas passing on `default_env` to SSHKit needed to happen on Kamal. cc @dhh, @HLFH See basecamp#432 (comment) for details.
filipesilva
force-pushed
the
sshkit-default-env
branch
from
3b72e62 to
561e33e
Compare
|
@filipesilva I have fixed the zsh issue in this PR: #1281. You can probably keep zsh? |
|
Oh sweet, that's even better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables deploy to MacOS hosts.
Will still need further configuration though:
default_envneeds to be set to a PATH that contains docker and coreutilscpcredsStorebashAll this can be done by the user though, whereas passing on
default_envto SSHKit needed to happen on Kamal.cc @dhh, @HLFH
See #432 (comment) for details.