Reuse CONTAINER_NAME constant #976
Open
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we |
|
I followed the conventions for other constants in the code base, they are not frozen. Also, starting from Ruby 3.4 strings will be frozen by default, so I don't think this is needed. |
|
@igor-alexandrov oh that’s lovely, good to know. |
igor-alexandrov
force-pushed
the
container-name-constant
branch
from
92c4a5e to
9d08d00
Compare
|
This has been rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reuses existing CONTAINER_NAME constant value instead of duplicating container name in a string.