Ensure X-Sendfile sends correct Content-Length
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases, `http.ServeFile` will set this for us. However, it will not set it if the response also has a `Content-Encoding`. (golang/go@fdc21f3) If we don't set (or at least clear) the header in that case, we'll pass through the `Content-Length` of the upstream's response, which can lead to us serving an incomplete response. In particular, this happens when Rails is serving a gzipped asset via `X-Sendfile`, which it does using `Content-Encoding: gzip` and `Content-Length: 0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases,
http.ServeFilewill set this for us. However, it will not set it if the response also has aContent-Encoding(see golang/go@fdc21f3).If we don't set (or at least clear) the header in that case, we'll pass through the
Content-Lengthof the upstream's response, which can lead to us serving an incomplete response.In particular, this happens when Rails is serving a gzipped asset via
X-Sendfile, which it does usingContent-Encoding: gzipandContent-Length: 0.Fixes #8.