OTP-19, rebar3 and hex package #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop-2.2 into develop
|
Thanks @tsloughter! Unfortunately, yeah, Riak is still stuck on R16 and Rebar 2 for now, so we won't be able to merge this yet 😖 . But, it'll definitely be good to have these changes ready to go once we do upgrade to a modern version of Erlang and a better build tool. I'll leave this PR open for now if you don't mind, and hopefully we'll be able to integrate some of these changes before too long. |
|
Sounds good. I'll keep this PR updated as best I can as well. |
|
👍 |
Use gen_fsm_compat for r20 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I doubt you'll want to merge this as is, but I wanted to open it since I just noticed there has been a good bit of recent work on this repo and I don't want them to end up diverging a lot. So I'm opening this to start the discussion.
I've been hosting the package under the name
riak_ensemble_ngto signal that it is not exactly the same as riak_ensemble: https://hex.pm/packages/riak_ensemble_ng