Develop 3.0 lastgaspring #1729
Merged
Develop 3.0 lastgaspring #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise a wave of crashing vnode starts can generate log noise during shutdown
But this appears to do so in a safer way
The tick on the backend is very aggressive. So wait 20 ticks of a stable ring before reacting. It would be preferable if other processes react to significant ring changes because of basho/riak_ensemble#129. Perhaps this shouldn't do anything at all?
|
@ThomasArts - this makes use of the lastgasp on the ring to avoid some of the log noise issues. Also has the necessary additional changes to stop riak_ensemble from firing off the last gasp ring. |
ThomasArts
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See basho/riak_core#945
This depends on this riak_core PR.
Last gasp monitoring added in all 3 places where ensemble tries to react to ring changes. Also blocks vnodes starting on a lastgasp ring.