Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NG-Scope SDR parameters configurable #33

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bastian-src
Copy link
Owner

@bastian-src bastian-src commented Dec 2, 2024

  • Add default config parsing test
  • Add partial config (missing fields) parsing test
  • Add NG-Scope parameters to confy

* Add default config parsing test
* Add partial config (missing fields) parsing test
@bastian-src bastian-src force-pushed the feature/ngscope_serial_configurable branch 2 times, most recently from 5ed20b2 to 92ec75c Compare December 5, 2024 23:14
Provide the option to pass NG-Scope SDR configuration
to set an SDR's serial number and NG-Scope cell parameter n_id.

Limit to three SDRs (a, b, and c).
@bastian-src bastian-src force-pushed the feature/ngscope_serial_configurable branch from ad5cf8d to 5bf81b7 Compare December 5, 2024 23:56
@bastian-src
Copy link
Owner Author

@justus237 I just finished this PR, can you test it from this feature branch?

Be aware to make a backup of your existing default-config and/or add the following parameters to the existing ngscope block:

ngscope:
...
  ng_sdr_config:
    ng_sdr_a:
      ng_sdr_a_serial: <some SDR serial number>
      ng_sdr_a_n_id: -1
    ng_sdr_b:
      ng_sdr_b_serial: <some SDR serial number>
      ng_sdr_c_n_id: -1
    ng_sdr_c:
      ng_sdr_c_serial: <some SDR serial number>
      ng_sdr_c_n_id: -1

or just a single SDR:

ngscope:
...
  ng_sdr_config:
    ng_sdr_a:
      ng_sdr_a_serial: <some SDR serial number>
      ng_sdr_a_n_id: -1
    ng_sdr_b: null
    ng_sdr_c: null

If you approve, I'll merge it to main 🐧

@justus237
Copy link

justus237 commented Dec 6, 2024

So the single SDR setup still works, but it does not actually make use of multiple SDRs. Not sure whether this is a limitation of DevicePublisher? At the start UECellTracker only prints a single cell. The /api/v1/celldata/connected/all returns a single cell, but network signal guru definitely says that the phone is using CA. Changing the path to /api/v1/celldata/all doesn't really help, because then UECellTracker just keeps initializing ng-scope over and over, because all connected and available cells changes quite frequently.

You need to set ng-scope's nof_rf_dev to the number of SDRs and ng-scope throws an error if you try to listen to the same base station (presumably same EARFCN) with two SDRs. As a result, I think it makes sense to assume 2xCA and just maybe modify DevicePublisher? Would need some hints on how to get the App onto the phone though.

Incorporate config-based ng_sdr_config instead of static
default parameters.
@bastian-src bastian-src force-pushed the feature/ngscope_serial_configurable branch from 5bf81b7 to 5ad5a0c Compare January 16, 2025 18:23
fix cli args causing null values in config
@bastian-src
Copy link
Owner Author

@justus237 I've added setting nof_rf_dev according to the current number of SDRs (considering the number of cells) as discussed.
Moreover, I've cherry-picked your changes from https://github.com/justus237/UECellTracker/tree/fix/cli-args and applied them to this PR. I can see if there are too many changes now for an actual review, but maybe you can give it another try on the hardware? Also, I'm not "overwriting" the .yaml config anymore.

I've also added tests which verify that parameters, which are not part of the .yaml config, will now be filled with the constat defaults. 🐳

@justus237
Copy link

justus237 commented Jan 19, 2025

For some reason the rnti matcher isn’t running (the pattern also doesnt show up in bmon; I’m not sure I’ll have time to root cause this next week) but ng-scope is configured correctly and starting correctly (currently just manually waiting until the devicepublisher shows the two CA cells near me.. :D but this should realistically be what we get from the API so this LGTM).

@bastian-src
Copy link
Owner Author

@justus237 can you test with a single SDR too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants