Plot violins in a specified order #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastibe
requested changes
Jul 10, 2019
added 3 commits
July 17, 2019 15:08
Added a test script to test the default violinplot and the new plot ordering option before I make further changes
Resolve the spacing/ formatting request
Updated the vararg parsing. Not sure it's ended upsimpler but it is a bit more robust
|
Did the requested changes. Also added a test case script to make sure my changes don't break anything - that's in a separate commit 03f0ed2 - up to you whether you want that one as well |
|
Cool, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional argument 'GroupOrder', {OrderCell} which allows the order of side by side violins to be specified.
It's a bit hacky as this is done in violinplot.m rather than the Violin class but this seemed the simplest way to do it.
Currently only tested using the data input format (Data,Label) as this is what I use. Looking at how categories work it should work fine anyway though.