[New Features] Quartiles styles, half violins and histograms on the side #38
Conversation
Added options for plotting only half violin on the right, left or full, independently of comparison or not. 'vHalf' Added plot quartiles options as shadow, boxplot or none. 'qStyles' Added plot data as histogram on the side. 'barpltBool' Added opt to disable scatter plot. 'scpltBool' Added test cases. modified: Violin.m modified: test_cases/testviolinplot.m
modified: Violin.m Added options for plotting only half violin on the right, left or full, independently of comparison or not. 'vHalf' Added plot quartiles options as shadow, boxplot or none. 'qStyles' Added plot data as histogram on the side. 'barpltBool' Added opt to disable scatter plot. 'scpltBool' modified: test_cases/testviolinplot.m Added new test cases to test this options. Change to subplots to prevent opening 7 figures.
modified: Violin.m Added options for plotting only half violin on the right, left or full, independently of comparison or not. 'vHalf' Added plot quartiles options as shadow, boxplot or none. 'qStyles' Added plot data as histogram on the side. 'barpltBool' Added opt to disable scatter plot. 'scpltBool' modified: test_cases/testviolinplot.m Added new test case, to test and show how do they work.
|
Thank you! This is awesome! I would ask you however to rename the parameters vHalf, qStyles, barpltBool to match the style of the remainder of the parameters, e.g. to HalfViolin, ShowQuartiles, ShowHistogram. Also, I think scpltBool is a duplication of ShowData, and should be removed. |
…p was also performed. Removed the boolean parameter 'scpltBool' and 'barpltBool' in favour of 'DataStyles. HalfViolin - Whether to do a half violin(left, right side) or full. Defaults to full. QuartileStyle - Option on how to display quartiles, with a boxplot, shadow or none. Defaults to boxplot. DataStyle - Defines the style to show the data points. Opts: 'scatter', 'histogram' or 'none'. Default is 'scatter'. modified: Violin.m modified: test_cases/testviolinplot.m
As requested, the names of the parameters have been changed, a small clean up was also performed. HalfViolin - Whether to do a half violin(left, right side) or full. Defaults to full. I kept the ShowData, because of the method, now it also removes the histogram. |
|
Great work! This looks really good! Thank you so much! Regrettably, Github doesn't show me a proper diff, and anyways I don't have access to Matlab any longer, so I can't really test your code in any meaningful way. But I'll trust you that everything works as it should. Does the original test suite still run? We don't want to break existing code. If all of that is in order, I'll gladly merge your contribution when you say it's ready. |
|
Thanks to you! Yeah! I also notice that Github oddly did not show proper differences, although in VSCode it does for me... I don't have access to Matlab any longer And yes, the original test, still runs, in fact, the modified From my side, everything is ready so merge at your wish! Have a nice day! |
|
Perfect! If you'd like to help maintain the Violinplot, I'd be happy to have you on board! |
|
|
I've sent you an invite to become a collaborator on this repository! Thank you for your help! |
|
Would you like to add your cool new graph variants to the screenshot in the README? |
This pull request includes several new features.
Notes:
I did these changes before the last changes were made, therefore new features are not fully implemented with the comparison mode. However, I did ensure that these changes did not break anything, in the future, a clean-up can be made to not repeat so much how jitter is generated.
Todo:
For the sake of simplicity I leave here the new output from the test function: