Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "shadow" quartiles delimiters were not perfectly horizontal #63

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

cellomario
Copy link
Contributor

Hi there and thank you for your wonderful tool,

When using the "shadow" mode to visualize the quartile ranges, the highlighted portion of the violin was cut in a non-horizontal fashion due to an off-by-one error. I fixed that.

Old behavior:

image

New behavior:

image

Copy link
Collaborator

@mikelgg93 mikelgg93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no Matlab to test it, but the change in the code looks good, and the screenshots too! Perhaps if you have the time you could recreate the figure in the README

@mikelgg93
Copy link
Collaborator

This fixes #59

@cellomario
Copy link
Contributor Author

Will do.

Do you have the script to generate it? It could be included in the repository as an usage example

@mikelgg93
Copy link
Collaborator

Unfortunately, I had it locally only, and I no longer have that laptop.

@bastibe
Copy link
Owner

bastibe commented Aug 5, 2023

Wonderful! This looks much better! Thank you for the Pull Request.

Regrettably, I don't have access to Matlab any longer, either, and neither do I have the script for the README plot.

@cellomario
Copy link
Contributor Author

Done! it's not exactly the same as I was not able to do the weird horizontal offset in the "Italy +1.5" column, and I am not familiar with the colormap you used, so I used the default one, but it's a useful starting point, feel free to modify it when you decide to merge my contributions

1 similar comment
@cellomario
Copy link
Contributor Author

Done! it's not exactly the same as I was not able to do the weird horizontal offset in the "Italy +1.5" column, and I am not familiar with the colormap you used, so I used the default one, but it's a useful starting point, feel free to modify it when you decide to merge my contributions

@bastibe
Copy link
Owner

bastibe commented Aug 31, 2023

Fantastic work, thank you so much!

I'll merge it when you say it's ready!

@cellomario
Copy link
Contributor Author

Then I'd say it's ready ;)

@bastibe bastibe merged commit edbba3c into bastibe:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants