-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'Orientation' parameter for vertical and horizontal layouts #73
Conversation
fhaefele
commented
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! This is super useful!
However, I don't like the way the plotOrientation
function makes the code harder to reason about in some places. I have sketched out an alternative structure that I'd prefer.
Nevertheless, great work, and thank you very much!
…cal or horizontal layout.
…lity and maintainability
…lity and maintainability
Hm, merging and resolving conflicts is still pretty new to me. I gave it my best. Also I have addressed all of your comments. Let me know if everything fits now, else I will try to fix it asap. I was also thinking of including that 'parent' property which you discussed in the other PR. I also don't know whether you saw that I made changes to violinplot.m as well. I hope those are fine as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better, thank you!
Just one more quick note: Could you format the code with spaces after operators (such as commas), so it matches the rest of the code?
Otherwise, this looks good to me!
Should be done and ready to merge. Do you want to also add the 'parent' property from #24 ? Should be an easy inclusion. |
That would be a good idea, thank you! |
I have added now the parent property and checked the functionality of the orientation swap and the 'parent' axis in a modified |
Looks good to me! Thank you! If you want to, you could add an example to the README. Is this ready to merge on your end? |
Yeah on my end it should be ready. However, if you want me to add an example in the README, then we should maybe wait with merging. The same goes for the |
I'll leave it up to you whether you want to add it to the README. |
I have edited the README and the |
Beautiful! Thank you! |