chore(infra): apply suggestions from deepsource for js code

bastienbeurier · Dec 6, 2022 · cb0bc61 · cb0bc61
1 parent eb5ef33
commit cb0bc61
Show file tree

Hide file tree

Showing 10 changed files with 24 additions and 14 deletions.
diff --git a/apps/api/src/app/change/usecases/promote-feed-change/promote-feed-change.ts b/apps/api/src/app/change/usecases/promote-feed-change/promote-feed-change.ts
@@ -7,7 +7,7 @@ export class PromoteFeedChange {
   constructor(private feedRepository: FeedRepository) {}
 
   async execute(command: PromoteTypeChangeCommand) {
-    let item: FeedEntity | undefined = undefined;
+    let item: FeedEntity | undefined;
     if (command.item.name) {
       item = await this.feedRepository.findOne({
         _environmentId: command.environmentId,

diff --git a/apps/api/src/app/events/usecases/send-message/send-message.usecase.ts b/apps/api/src/app/events/usecases/send-message/send-message.usecase.ts
@@ -120,7 +120,7 @@ export class SendMessage {
       return filter?.children?.find((item) => item?.on === 'subscriber');
     });
 
-    let subscriber = undefined;
+    let subscriber;
 
     if (fetchSubscriber) {
       /// TODO: refactor command.subscriberId to command._subscriberId

diff --git a/apps/api/src/app/logs/usecases/create-log/create-log.usecase.ts b/apps/api/src/app/logs/usecases/create-log/create-log.usecase.ts
@@ -11,8 +11,9 @@ export class CreateLog {
     if (command.raw) {
       try {
         rawData = JSON.stringify(command.raw);
-        // eslint-disable-next-line no-empty
-      } catch (e) {}
+      } catch (error) {
+        console.error('Parsing raw data when creating a log failed', error);
+      }
     }
 
     //

diff --git a/apps/web/cypress/tests/auth.spec.ts b/apps/web/cypress/tests/auth.spec.ts
@@ -131,7 +131,7 @@ describe('User Sign-up and Login', function () {
       cy.getByTestId('submit-btn').click();
 
       // setting current time in future, to simulate expired token
-      var todaysDate = new Date();
+      const todaysDate = new Date();
       todaysDate.setDate(todaysDate.getDate() + 30); // iat - exp = 30 days
       cy.clock(todaysDate);
 

diff --git a/apps/web/src/components/layout/components/SideNav.tsx b/apps/web/src/components/layout/components/SideNav.tsx
@@ -164,13 +164,23 @@ export function SideNav({}: Props) {
           <OrganizationSelect />
         </Navbar.Section>
         <BottomNav dark={dark} data-test-id="side-nav-bottom-links">
-          <a target="_blank" href="https://discord.novu.co" data-test-id="side-nav-bottom-link-support">
+          <a
+            target="_blank"
+            rel="noopener noreferrer"
+            href="https://discord.novu.co"
+            data-test-id="side-nav-bottom-link-support"
+          >
             Support
           </a>
           <p>
             <b>&nbsp;&nbsp;&nbsp;•&nbsp;&nbsp;&nbsp;</b>
           </p>
-          <a target="_blank" href="https://docs.novu.co" data-test-id="side-nav-bottom-link-documentation">
+          <a
+            target="_blank"
+            rel="noopener noreferrer"
+            href="https://docs.novu.co"
+            data-test-id="side-nav-bottom-link-documentation"
+          >
             Documentation
           </a>
         </BottomNav>

diff --git a/apps/web/src/pages/templates/workflow/WorkflowEditorPage.tsx b/apps/web/src/pages/templates/workflow/WorkflowEditorPage.tsx
@@ -241,7 +241,7 @@ const WorkflowEditorPage = ({
 
                     <Text mr={10} mt={10} size="md" color={colors.B60}>
                       Configure the digest parameters. Read more about the digest engine{' '}
-                      <a target={'_blank'} href={'https://docs.novu.co/platform/digest'}>
+                      <a target={'_blank'} rel="noopener noreferrer" href={'https://docs.novu.co/platform/digest'}>
                         here
                       </a>
                       .

diff --git a/apps/widget/cypress/support/commands.ts b/apps/widget/cypress/support/commands.ts
@@ -71,7 +71,7 @@ Cypress.Commands.add('initializeSession', function (settings = {} as IInitialize
       cy.log(`Widget initialized: ${session.subscriberId}`);
     })
     .then((session: any) => {
-      let encryptedHmacHash: string | undefined = undefined;
+      let encryptedHmacHash: string | undefined;
 
       if (settings.hmacEncryption) {
         cy.task('enableEnvironmentHmac', {

diff --git a/docs/src/theme/DocPage/index.js b/docs/src/theme/DocPage/index.js
@@ -1,6 +1,5 @@
-import React from 'react';
+import React, { createContext } from 'react';
 import DocPage from '@theme-original/DocPage';
-import { createContext } from 'react';
 
 export const SidebarContext = createContext('default');
 

diff --git a/docs/src/theme/Footer/Links/MultiColumn/index.js b/docs/src/theme/Footer/Links/MultiColumn/index.js
@@ -37,7 +37,7 @@ function SideColumn() {
         className="footer__button"
         href="https://github.com/novuhq/novu"
         target="_blank"
-        rel="noopener"
+        rel="noopener noreferrer"
       >
         Star us on GitHub
       </a>

diff --git a/libs/embed/src/embed.ts b/libs/embed/src/embed.ts
@@ -122,7 +122,7 @@ class Novu {
     }
 
     function hideWidget() {
-      var elem = document.querySelector('.wrapper-novu-widget') as HTMLBodyElement;
+      const elem = document.querySelector('.wrapper-novu-widget') as HTMLBodyElement;
 
       if (elem) {
         elem.style.display = 'none';
@@ -134,7 +134,7 @@ class Novu {
         _scope.widgetVisible = !_scope.widgetVisible;
         positionIframe();
 
-        var elem = document.querySelector('.wrapper-novu-widget') as HTMLBodyElement;
+        const elem = document.querySelector('.wrapper-novu-widget') as HTMLBodyElement;
 
         if (elem) {
           elem.style.display = 'inline-block';