Implements multi selector for library type for Emby/Jellyfin. Allows… #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for multiselect using array style notation in yaml. Also updated docs to reflect change Fixes bastienwirtz#681
❌ Deploy Preview for homer-demo-content failed.
|
cmatute7712
changed the title
|
Really hope this is able to be merged in soon, been wanting this feature for a while now |
| else if (this.item.libraryType === "series") | ||
| return `${this.episodeCount} eps, ${this.seriesCount} series`; | ||
| else return `wrong library type 💀`; | ||
| const libraryType = this.item.libraryType; |
There was a problem hiding this comment.
We can avoid a breaking change with somethong like this
Suggested change
| const libraryType = this.item.libraryType; | |
| // ensure retro-compatibility with previous implementation | |
| const libraryType = Array.isArray(this.item.libraryType) ? this.item.libraryType : [this.item.libraryType]; |
| const libraryType = this.item.libraryType; | ||
| const counts = []; | ||
|
|
||
| libraryType.forEach((type, index) => { |
There was a problem hiding this comment.
Suggested change
| libraryType.forEach((type, index) => { | |
| libraryType.forEach((type) => { |
| const counts = []; | ||
|
|
||
| libraryType.forEach((type, index) => { | ||
| if (type === "music") { |
There was a problem hiding this comment.
nit: a switch could be nicer ?
| } | ||
| }); | ||
|
|
||
| const allowedParams = this.item.embyCountParams || ""; |
There was a problem hiding this comment.
What is this.item.embyCountParams ? the embyCountParams is not documented (or I'm missing something?)
There was a problem hiding this comment.
I'm not sure to get what the code below around the filter logic is about 🤔
bastienwirtz
force-pushed
the
main
branch
2 times, most recently
from
12cad12 to
474dc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements multi selector for library type for Emby/Jellyfin. Allows for multiselect using array style notation in yaml. Also updated docs to reflect change
Fixes #681
Type of change
Checklist:
config.ymlfile