Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batocera-wine: fix save_install() - Wine refused to work then #13666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crcerror
Copy link
Contributor

@crcerror crcerror commented Mar 5, 2025

  • Renamed save_install() -> saveFileToUserdata()
  • fixed mv and symlinking to SAVES_WINDIR, would return 1 and therefore WINE did refuse to work
  • Added remarks for better mantaining the script

Thanks @aderumier for the WINE-Save idea
@nadenislamarre please review

old PR -> #13656

- Renamed save_install() -> saveFileToUserdata()
- fixed mv and symlinking to SAVES_WINDIR, would return 1 and therefore WINE did refuse to work
- Added remarks for better mantaining the script
@nadenislamarre
Copy link
Collaborator

there is no error control ?

" cp -r "${WINE_SAVEDIR}/." "${SYSTEM_SAVEDIR}" " for example ?
(ok it was like it before...)

@crcerror
Copy link
Contributor Author

crcerror commented Mar 5, 2025

Well there is an error-control. The function is introduced with:
fileSavesToUserdata || return 1
And it works.... the old script tried to move or link into the SYSTEM_SAVEDIR for example and failed. This leaded to refuse the start of WINE. The error-control could be better .... but I think we should have a 80% good working script now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants