Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the library compile with GHC 7.7 and base 4.7 #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

co-dan
Copy link

@co-dan co-dan commented Jun 25, 2013

Functor instances for ArgDescr and OptDescr are now defined in base 4.7

@23Skidoo
Copy link

23Skidoo commented Jul 7, 2013

You should have used the MIN_VERSION_base macro to make the code compatible with base < 4.7:

#if !MIN_VERSION_base(4,7,0)
instance Functor OptDescr...
#endif

@co-dan
Copy link
Author

co-dan commented Jul 7, 2013

@23Skidoo Yeah, that actually makes a lot of sense, I don't know why I ditched the instances completely.

Thanks.

@peti
Copy link

peti commented Aug 17, 2013

Could you please release a new version of the library that contains this patch? Many of my attempts to compile software with GHC 7.7 fail because of that issue http://hydra.cryp.to/build/8647/nixlog/1/raw.

@23Skidoo
Copy link

@peti Max (@batterseapower) seems to be ignoring this issue tracker. I've sent him an email.

@bos
Copy link
Contributor

bos commented Oct 9, 2013

I've forked the repo to haskell/test-framework and fixed this bug there.

@23Skidoo
Copy link

23Skidoo commented Oct 9, 2013

@bos Great. I've tried to reach the author by e-mail, but he didn't respond.

@co-dan
Copy link
Author

co-dan commented Oct 9, 2013

Nice to hear that!
I've also heard that test-framework is abandoned and that's why Roman
Cheplyaka has created tasty

On Wed, Oct 9, 2013 at 4:19 AM, bos [email protected] wrote:

I've forked the repo to haskell/test-frameworkhttps://github.com/haskell/test-frameworkand fixed this bug there.


Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-25938462
.

Sincerely yours,
-- Daniil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants