Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some (maybe) useful utilities for protobuf #153

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

TeoGiane
Copy link
Contributor

@TeoGiane TeoGiane commented Mar 6, 2024

Summary

  1. Fix wrong protobuf include directories, link libraries and protoc executable. We now explicitly use the version we locally install during configuration.
  2. Add the cmake/ProtobufUtils.cmake file, which contains a cmake function that encapsulates the previous code we adopted to generate cpp and python files from the proto messages.

Copy link
Contributor

@brunoguindani brunoguindani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😊

Copy link
Contributor

@mberaha mberaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the effort :)

@TeoGiane TeoGiane merged commit 9fdfa09 into bayesmix-dev:master Mar 10, 2024
2 checks passed
@TeoGiane TeoGiane deleted the protobuf_utils branch March 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants