Skip to content

Commit

Permalink
Don't iterate depsets in objc providers (#1835)
Browse files Browse the repository at this point in the history
  • Loading branch information
jayconrod authored and Jay Conrod committed Nov 28, 2018
1 parent 84e5081 commit 01e5a9f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions go/private/rules/cgo.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,11 @@ def _cgo_codegen_impl(ctx):
linkopts.extend(d.cc.link_flags)
elif hasattr(d, "objc"):
cppopts.extend(["-D" + define for define in d.objc.define.to_list()])
for inc in d.objc.include:
for inc in d.objc.include.to_list():
_include_unique(cppopts, "-I", inc, seen_includes)
for inc in d.objc.iquote:
for inc in d.objc.iquote.to_list():
_include_unique(cppopts, "-iquote", inc, seen_quote_includes)
for inc in d.objc.include_system:
for inc in d.objc.include_system.to_list():
_include_unique(cppopts, "-isystem", inc, seen_system_includes)

# TODO(jayconrod): do we need to link against dynamic libraries or
Expand Down

0 comments on commit 01e5a9f

Please sign in to comment.