Skip to content

Commit

Permalink
Remove uses of deprecated dictionary concatenation (#1663)
Browse files Browse the repository at this point in the history
This removes the need for --incompatible_disallow_dict_plus
  • Loading branch information
jjudd authored and Jay Conrod committed Nov 30, 2018
1 parent 735c29e commit 48233e6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions go/private/rules/binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _go_binary_impl(ctx):

go_binary = go_rule(
_go_binary_impl,
attrs = {
attrs = dict({
"deps": attr.label_list(
providers = [GoLibrary],
aspects = [go_archive_aspect],
Expand Down Expand Up @@ -145,19 +145,19 @@ go_binary = go_rule(
values = GOARCH.keys() + ["auto"],
default = "auto",
),
} + _SHARED_ATTRS,
}.items() + _SHARED_ATTRS.items()),
executable = True,
)
"""See go/core.rst#go_binary for full documentation."""

go_tool_binary = go_rule(
_go_binary_impl,
bootstrap = True,
attrs = {
attrs = dict({
"deps": attr.label_list(providers = [GoLibrary]),
"embed": attr.label_list(providers = [GoLibrary]),
"_hostonly": attr.bool(default = True),
} + _SHARED_ATTRS,
}.items() + _SHARED_ATTRS.items()),
executable = True,
)
"""
Expand Down

0 comments on commit 48233e6

Please sign in to comment.