Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
lib/compatibility.bzl
#381base: main
Are you sure you want to change the base?
Add
lib/compatibility.bzl
#381Changes from 25 commits
fa9f398
e86f542
b6a5584
52b2e62
8190b2e
b3d4463
977a070
63d9712
e202c2b
4b34b67
6abd9ad
dc846a0
73b0ed8
5b4c97c
b77d66e
7568466
bf4a2cd
ee916b0
7939c78
c333bc4
d935d67
ded484c
8d07e16
0ee8b41
04caadf
6765506
76a22f4
0d87298
9eb896e
d27b58d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you replace
"@bazel_skylib//lib/compatibility:all_of_{}".format(i)
with"@platforms//:incompatible"
in this line?It if works, it's much simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as #381 (comment)
EDIT: Fixed link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one alternative, which I considered worse until now. How about:
I think this should evaluate to a single label when a condition is not met.
First line could also be
result = settings
. That might work better incquery
-es.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit that I am struggling to follow your code snippet. Using
setting: result,
inside the dictionary means that we're nestingselect()
statements. Which is, as far as I can tell, not allowed. bazelbuild/bazel#1623 (comment)Bazel also gets unhappy because the types of each
select()
path no longer match: