Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve analysis cache through --run_under command changes #24411

Closed
wants to merge 4 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 20, 2024

Work towards #3325
Fixes #10782

RELNOTES: Changing any part of --run_under that isn't the label (such as the shell command) no longer invalidates the analysis cache.

@fmeum fmeum requested a review from a team as a code owner November 20, 2024 14:26
@fmeum fmeum requested review from katre and removed request for a team November 20, 2024 14:26
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Nov 20, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 20, 2024

@katre This is my attempt at a rollforward of #24303. I am no longer trimming the CoverageOptions, but also keeping the analysis cache when they change. I'm not sure that's correct, but it should preserve the current behavior.

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 4, 2024

@katre Friendly ping

Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks good, I'll import and test ASAP.

@katre katre removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 4, 2024
@katre
Copy link
Member

katre commented Dec 4, 2024

I'll handle merging and testing.

@copybara-service copybara-service bot closed this in 45d4cff Dec 6, 2024
@fmeum fmeum deleted the 10782-run-under branch December 6, 2024 17:23
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 6, 2024

@bazel-io flag

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 6, 2024

(for 8.1.0)

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2024
@iancha1992
Copy link
Member

@bazel-io fork 8.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 10, 2024
@iancha1992 iancha1992 self-assigned this Jan 22, 2025
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jan 22, 2025
*** Reason for rollback ***

Rollforward with fixes

Preserve analysis cache through `--run_under` command changes

Work towards bazelbuild#3325
Fixes bazelbuild#10782

RELNOTES: Changing any part of --run_under that isn't the label (such as the shell command) no longer invalidates the analysis cache.

Closes bazelbuild#24411.

PiperOrigin-RevId: 703516108
Change-Id: Ief9bd2547fe87b4c09b132ada87aed369753e550
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2025
*** Reason for rollback ***

Rollforward with fixes

Preserve analysis cache through `--run_under` command changes

Work towards #3325 Fixes
#10782

RELNOTES: Changing any part of --run_under that isn't the label (such as
the shell command) no longer invalidates the analysis cache.

Closes #24411.

PiperOrigin-RevId: 703516108
Change-Id: Ief9bd2547fe87b4c09b132ada87aed369753e550

Commit
45d4cff

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--run_under discards analysis cache
4 participants